GDExtension: Fixed error on loading extensions #83734
Merged
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, before loading an extension, the editor just tried to retrieve the extension by path to test if it's been loaded already. While this is handled gracefully, it ignored an error thrown inside `GDExtensionManager::get_extension()`, that would essentially still report a not yet loaded extension to the engine's log: ``` ERROR: Condition "!E" is true. Returning: Ref<GDExtension>() at: GDExtensionManager::get_extension (core\extension\gdextension_manager.cpp:165) ``` This change actively checks whether the extension path is known and only then proceeds to actually return the already loaded extension or loads and returns the new one otherwise.
dsnopek
approved these changes
Oct 21, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, before loading an extension, the editor just tried to retrieve the extension by path to test if it's been loaded already.
While this is handled gracefully, it ignored an error thrown inside
GDExtensionManager::get_extension(), that would essentially still report a not yet loaded extension to the engine's log:This change actively checks whether the extension path is known and only then proceeds to actually return the already loaded extension or loads and returns the new one otherwise.